Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hanging straxer #1065

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix hanging straxer #1065

merged 1 commit into from
Jul 18, 2022

Conversation

jmosbacher
Copy link
Contributor

status thread is keeping straxer from exiting when the work is done. This PR is a trivial fix, just adding daemon=True when creating the thread so it exits when the main thread exits.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 93.212% when pulling 0054ba9 on fix_straxer_hanging into 6c0a571 on master.

JoranAngevaare
JoranAngevaare approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@JoranAngevaare JoranAngevaare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yossi!

@JoranAngevaare JoranAngevaare merged commit aeddb6a into master Jul 18, 2022
@JoranAngevaare JoranAngevaare deleted the fix_straxer_hanging branch July 18, 2022 07:34
@JoranAngevaare JoranAngevaare added the enhancement New feature or request label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoranAngevaare JoranAngevaare JoranAngevaare approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmosbacher @coveralls @JoranAngevaare